[range.istream] Start CharT and Traits with lowercase
#6032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohelEGP
approved these changes
Dec 19, 2022
|
@jwakely Does this fit into a general policy? |
|
It's consistent with our style for everything using |
|
I see, thanks! Would it be desirable to change everything else to uppercase? |
|
Maybe ... but I should probably run that past the group. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that whether it is
basic_istream/basic_ostreamin<iosfwd>,istream_iterator/ostream_iteratorin<iterator>,string/string_viewin<string>,formatterin<format>,their template parameters
charT/traitsall start with lowercase.We should make
istream_viewconsistent with such a style.