[class.compare] Don't introduce V for the return value
#6035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In both cases, I'm not sure introducing `V` helps much - just requires name lookup for `V`. If we just say "the return value" in every case, I think that's clearer.
jensmaurer
approved these changes
Dec 19, 2022
|
See also #6036 for some additional considerations for improving the wording here. |
|
This is a clear improvement, regardless of where #6036 goes. |
|
I'm not sure it's a "clear improvement": both versions seem equally reasonable, and one could make the case that a repeated concept should be named. I don't find this a super strong case, but am happy to hear others' position. Thoughts? |
One could, I guess, but the repeated concept in this case is only three words ("the return value"), is a very simple concept, and it is repeated only one time. |
tkoeppe
requested changes
Jan 24, 2023
Per suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In both cases, I'm not sure introducing
Vhelps much - just requires name lookup forV. If we just say "the return value" in every case, I think that's clearer.