Fix an example that got broken by P2499R0 #6041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hewillk
reviewed
Dec 30, 2022
|
Do I need to do some further change? |
CaseyCarter
approved these changes
Jan 18, 2023
|
Can you please update the commit message according to https://github.com/cplusplus/draft/wiki/Commit-message-format#editorial-commits? |
…ng_view in the example After P2499R0 it is no longer possible to implicitly construct a string_view out of a range (like the ones produced by views::split). As a solution, use explicit construction instead. This is purely editorial, as it affects only the example code. Fixes cplusplus#6017
|
@tkoeppe, looks like this is ready now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After P2499R0 it is no longer possible to implicitly construct a string_view out of a range (like the ones produced by views::split). Use explicit construction instead.
Fixes #6017