[reverse.iter.conv] Remove unclear explicit comments #6056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know what explicit refers to here, it seems to be more appropriate to remove. People who disagree with me are also welcome.
CaseyCarter
approved these changes
Jan 22, 2023
There was a problem hiding this comment.
This comment has been present since C++98, which had a similar comment on basic_string_view::c_str. I guess these comments are trying to tell us that the pertinent member functions are like explicit conversions? If we don't know what they mean today, they provide no value; I'm happy to remove them.
|
@jwakely, any insight here? Otherwise, this looks like good riddance to me. |
jwakely
approved these changes
Jan 23, 2023
Alternatively, we could change them to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know what explicit refers to here, it seems to be more appropriate to remove. People who disagree with me are also welcome.