Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tab:iostreams.summary] Add missing header in summary table #6079

Merged
merged 2 commits into from Mar 13, 2023

Conversation

alexriegler
Copy link
Contributor

Fixes #6072

@@ -27,7 +27,7 @@
\ref{iostreams.base} & Iostreams base classes & \tcode{<ios>} \\ \rowsep
\ref{stream.buffers} & Stream buffers & \tcode{<streambuf>} \\ \rowsep
\ref{iostream.format} & Formatting and manipulators &
\tcode{<iomanip>}, \tcode{<istream>}, \tcode{<ostream>} \\ \rowsep
\tcode{<iomanip>}, \tcode{<istream>}, \tcode{<ostream>}, \tcode{<print>} \\ \rowsep
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this list was in alphabetical order already so I preserved that. Is that what we wanted?

If so, would it be worth reordering the "C library files" because they are not in alphabetical order.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, one is in alphabetical order, and the other in order of appearance... I don't feel super strongly that anything needs to be changed, but I also wouldn't push back too hard against a reordering (either way).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think order of appearance makes sense, Otherwise it'd be in random order which would be annoying.

@tkoeppe tkoeppe merged commit 29c0c3d into cplusplus:main Mar 13, 2023
2 checks passed
@alexriegler alexriegler deleted the missing_print branch March 13, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<print> header is missing in Table 118
2 participants