Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LWG 3] P2790R0 Immediate issues except 3441 #6116

Merged
merged 32 commits into from Mar 7, 2023
Merged

[LWG 3] P2790R0 Immediate issues except 3441 #6116

merged 32 commits into from Mar 7, 2023

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Feb 15, 2023 •
edited by jensmaurer

Fixes #6093.
Fixes #5800.
Fixes cplusplus/papers#1479
Fixes cplusplus/papers#1368
Fixes cplusplus/nbballot#463
Fixes cplusplus/nbballot#454
Fixes cplusplus/nbballot#453
Fixes cplusplus/nbballot#452
Fixes cplusplus/nbballot#447
Fixes cplusplus/nbballot#444

LWG3631: Were both declarations of handle in [format.arg] intended to be changed?

@burblebee burblebee marked this pull request as draft February 15, 2023 16:57
@burblebee burblebee changed the title Motions 2023 02 lwg 3 [LWG 3] P2790R0 Immediate issues except 3441 Feb 15, 2023
@burblebee burblebee marked this pull request as ready for review February 15, 2023 17:28
JohelEGP
JohelEGP suggested changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some \linebreak{}s at places where line breaks should occur naturally. Why is that? Shouldn't \- be encouraged more because it maintains justification?

source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/containers.tex Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/iostreams.tex Outdated Show resolved Hide resolved
source/compatibility.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/ranges.tex Show resolved Hide resolved
@jensmaurer jensmaurer added this to the post-2023-02 milestone Feb 16, 2023
@burblebee
Copy link
Contributor Author

I see some \linebreak{}s at places where line breaks should occur naturally. Why is that? Shouldn't \- be encouraged more because it maintains justification?

I tried \- as well as \brk{} but couldn't get either to work (Latex seems to only listen to those "hints" if they occur where Latex would normally want to break a line). But yes, those "hints" are preferred; \linebreak{} forces a hard break before the ending margin which is ugly.

JohelEGP
JohelEGP approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@JohelEGP JohelEGP left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, don't miss #6116 (comment), which is in an outdated comment.

@burblebee @tkoeppe
LWG3622 Misspecified transitivity of equivalence in §[unord.req.general]
08d1a06
@burblebee @tkoeppe
[unord.req.general] Use Oxford comma in wording for LWG3622.
87062d5
@burblebee @tkoeppe
LWG3631 basic_format_arg(T&&) should use remove_cvref_t<T> throughout
5502d2c 
[format.arg] Changed declartion of basic_format_arg::handle's ctor in class to match change in itemdecl.
@burblebee @tkoeppe
LWG3645 resize_and_overwrite is overspecified to call its callback wi…
8a0149a 
…th lvalues
@burblebee @tkoeppe
LWG3655 The INVOKE operation and union types
f8a9adc
@burblebee @tkoeppe
LWG3723 priority_queue::push_range needs to append_range
776bbdb
@burblebee @tkoeppe
LWG3734 Inconsistency in inout_ptr and out_ptr for empty case
afd3897
@burblebee @tkoeppe
LWG3772 repeat_view's piecewise constructor is missing Postconditions
f3a8614
@burblebee @tkoeppe
LWG3786 Flat maps' deduction guide needs to default Allocator to be u…
6138cb4 
…seful

[flat.set.defn][flat.multiset.defn] Clean up indentation for consistency.
@burblebee @tkoeppe
LWG3803 flat_foo constructors taking KeyContainer lack KeyCompare par…
c3a0969 
…ameter
@burblebee @tkoeppe
LWG3810 CTAD for std::basic_format_args
5fc48b4
@burblebee @tkoeppe
LWG3827 Deprecate <stdalign.h> and <stdbool.h> macros
632a868 
Fixes NB GB 081, GB 082 (C++23 CD).
@burblebee @tkoeppe
LWG3828 Sync intmax_t and uintmax_t with C2x
18314e6
@burblebee @tkoeppe
[cinttypes.syn] Use "," before "respectively" in wording for LWG3828.
c1aa3d2
@burblebee @tkoeppe
LWG3833 Remove specialization template<size_t N> struct formatter<con…
8160812 
…st charT[N], charT>
@burblebee @tkoeppe
LWG3865 Sorting a range of pairs
045f6e9
@burblebee @tkoeppe
LWG3869 Deprecate std::errc constants related to UNIX STREAMS
2a08af4
@burblebee @tkoeppe
LWG3870 Remove voidify
fa30269 
Fixes NB GB 121 (C++23 CD).
@burblebee @tkoeppe
LWG3871 Adjust note about terminate
74d0dca 
Fixes NB CA 076 (C++23 CD).
@burblebee @tkoeppe
LWG3872 basic_const_iterator should have custom iter_move
94ed1f4
@burblebee @tkoeppe
LWG3875 std::ranges::repeat_view<T, IntegerClass>::iterator may be il…
17630da 
…l-formed
@burblebee @tkoeppe
LWG3876 Default constructor of std::layout_XX::mapping misses precond…
2fa7a59 
…ition
@burblebee @tkoeppe
LWG3877 Incorrect constraints on const-qualified monadic overloads fo…
1e27830 
…r std::expected
@burblebee @tkoeppe
LWG3878 import std; should guarantee initialization of standard iostr…
aaf544e 
…eams objects
@burblebee @tkoeppe
LWG3879 erase_if for flat_{,multi}set is incorrectly specified
5bbbaf8
@burblebee @tkoeppe
LWG3880 Clarify operator+= complexity for {chunk,stride}_view::iterator
ef1d310
@burblebee @tkoeppe
LWG3881 Incorrect formatting of container adapters backed by std::string
89c1f6c
@tkoeppe tkoeppe merged commit 7b7db83 into main Mar 7, 2023
4 checks passed
@frederick-vs-ja frederick-vs-ja mentioned this pull request Mar 13, 2023
Closed
@tkoeppe tkoeppe deleted the motions-2023-02-lwg-3 branch May 10, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohelEGP JohelEGP JohelEGP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2023-02
Development

Successfully merging this pull request may close these issues.

GB-082 17.14.5 [stdbool.h.syn] Deprecate contents of <stdbool.h> GB-121 27.11.1 [specialized.algorithms.general] Remove voidify GB-080 17.4.1 [cstdint.syn] Sync intmax_t and uintmax_t with C2x GB-084 19.5.2 [system.error.syn] Deprecate std::errc constants related to UNIX STREAMS [flat.map.defn,flat.multimap.defn] Deduction guide needs to default Allocator to be useful LWG3786
GB-081 17.14.4 [stdalign.h.syn] Deprecate contents of <stdalign.h> CA-076 16.4.2.5p4 [compliance] Adjust note about terminate LWG3810 CTAD for std::basic_format_args [2023-02 LWG Motion 3] Immediate issues except 3441 in P2790R0 C++ Standard Library Immediate Issues to be moved in Issaquah, Feb. 2023 P2790 C++ Standard Library Immediate Issues to be moved in Issaquah, Feb. 2023
4 participants
@burblebee @JohelEGP @tkoeppe @jensmaurer