[LWG 2] P2789R0 Ready and Tentatively Ready issues #6124
Conversation
burblebee
force-pushed
the
motions-2023-02-lwg-2
branch
from
2b6b20e to
3c99eb3
Compare
| \begin{itemdescr} | ||
| \pnum | ||
| \effects | ||
| Equivalent to: \tcode{ranges::iter_swap(*x.\exposid{parent_}->\exposid{current_}, *y.\exposid{parent_}->\exposid{current_});} |
There was a problem hiding this comment.
| Equivalent to: \tcode{ranges::iter_swap(*x.\exposid{parent_}->\exposid{current_}, *y.\exposid{parent_}->\exposid{current_});} | |
| Equivalent to \tcode{ranges::iter_swap(*x.\exposid{parent_}->\exposid{current_}, *y.\exposid{parent_}->\exposid{current_})}. |
There was a problem hiding this comment.
Actually no; when we introduce code with "Equivalent to:" (note the trailing ":"), the code is supposed to be complete, as if in a codeblock that could be substituted. Your suggestion would apply if the code had been introduced using "Equivalent to", the idea being that later reads as a statement. That said, if this should be an expression and not a statement, then the ";" should be removed. Alternatively, we could use your suggestion and introduce it with "Equivalent to". What do you prefer?
There was a problem hiding this comment.
Ah, yes. Again, I forgot to remove the colon, too. Edited.
There was a problem hiding this comment.
I'm fine leaving it as proposed. We could make the change, but we don't have to, and that way we retain some symmetry between the two instances.
tkoeppe
force-pushed
the
motions-2023-02-lwg-2
branch
from
f7595dc to
211ee2d
Compare
… std-format-spec
…context::next_arg_id
…r-like The new overload is also marked as "freestanding", which was not part of the proposed issue resolution but matches the surrounding interface. Also inserts an Oxford comma in [pair.pair].
… functions should be noexcept
tkoeppe
force-pushed
the
motions-2023-02-lwg-2
branch
from
211ee2d to
a47bdd7
Compare
Fixes #6092.
Fixes cplusplus/papers#1478
Fixes cplusplus/nbballot#534
Also fixes cplusplus/papers#1311