Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CWG 8] P2736R2 Referencing The Unicode Standard #6126

Merged
merged 1 commit into from Mar 5, 2023
Merged

[CWG 8] P2736R2 Referencing The Unicode Standard #6126

merged 1 commit into from Mar 5, 2023

Conversation

jensmaurer
Copy link
Member

@jensmaurer jensmaurer commented Feb 15, 2023 •
edited

@jensmaurer jensmaurer added this to the post-2023-02 milestone Feb 15, 2023
JohelEGP
JohelEGP approved these changes Feb 18, 2023
View reviewed changes
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be a merge conflict with #6099. The paper for this PR mentions:

[Editor’s note: Merging with P2713R1 [ 1 ] should produce the following
wording:
[...]

@jensmaurer jensmaurer changed the title P2736R2 Referencing The Unicode Standard [CWG 8] P2736R2 Referencing The Unicode Standard Feb 19, 2023
@JohelEGP JohelEGP mentioned this pull request Feb 22, 2023
Merged
@JohelEGP
Copy link
Contributor

Also with #6144:

Drafting note 4: The following papers contain changes to some of the same paragraphs changed in this paper; merging will be required.

P2736 (Referencing The Unicode Standard)
P2675 (LWG3780: The Paper)

This was referenced Feb 22, 2023
Merged
Closed
@jensmaurer @tkoeppe
P2736R2 Referencing The Unicode Standard
d933548 
In [lex.name], the paper missed a change of the original term
"character classes" to "character properties"; that change is
included.

Fixes NB FR 133, FR 013 (C++23 CD).
tkoeppe
tkoeppe reviewed Mar 5, 2023
View reviewed changes
source/lex.tex
The character classes XID_Start and XID_Continue
are Derived Core Properties as described by \UAX{44}.
\begin{note}
The character properties XID_Start and XID_Continue are Derived Core Properties
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing "character classes" to "character properties" wasn't in the paper, but seems right; I added a note to the commit message.

@tkoeppe tkoeppe merged commit dd5992f into main Mar 5, 2023
@tkoeppe tkoeppe deleted the motions-2023-02-cwg-8 branch May 10, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoeppe tkoeppe tkoeppe left review comments

@JohelEGP JohelEGP JohelEGP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2023-02
3 participants
@jensmaurer @JohelEGP @tkoeppe