[LWG 11] P2572R1 std::format fill character allowances #6144
Conversation
burblebee
force-pushed
the
motions-2023-02-lwg-11
branch
from
c595b95
to
ff20388
Compare
burblebee
force-pushed
the
motions-2023-02-lwg-11
branch
from
77c5307
to
dae6572
Compare
There was a problem hiding this comment.
With regards to d721879, #6144 (comment) wasn't applied. Also, considering #6155 (comment), it'd be better to split the UCS -> Unicode change and the Unicode encoding ones in two commits, possibly reverting the Unicode encoding commit.
There was a problem hiding this comment.
Please, apply #6144 (review). The "Unicode encoding" to UTFN changes may be wrong.
tkoeppe
force-pushed
the
motions-2023-02-lwg-11
branch
from
420107a
to
e13ae01
Compare
|
@tahonermann Could you perhaps have a look if this merging with the changes from P2736R2 looks reasonable? |
|
@tkoeppe, the merge resolutions look good to me; the substitutions of "UTF-8, UTF-16, and UTF-32" for "Unicode encoding" and of "Unicode scalar value" for "UCS scalar value" appear to be consistent. I do see the FIXME notes related to the inability to display the clown face character and the omission of a few code lines in an example note due to it. If those can't be resolved, then additional changes are needed to the corresponding prose to not refer to the missing lines. |
|
@tahonermann Thanks! Rest assured that the DIS will include adequate amounts of clownery. |
The changes have been integrated with prior changes from P2736R2 (from CWG Motion 8).
tkoeppe
force-pushed
the
motions-2023-02-lwg-11
branch
from
e13ae01
to
b4fbb5d
Compare
|
@tkoeppe, how's it going getting them clowns added to the DIS? I have a goal of eventually adding an entire circus ;) |
Fixes #6101.
Note: Could not complete edits due to invalid ucn chars. Feel free to use my edits as a base and complete this if you can.
Fixes cplusplus/papers#1260
Fixes cplusplus/papers#1090
Fixes cplusplus/papers#1150