New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LWG 12] P2693R1 Formatting thread::id and stacktrace #6147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@burblebee, please fix the commit description. I'm fixing the title of this pull request. |
jensmaurer
changed the title
[LWG 12] P2572R1 std::format fill character allowances
[LWG 12] P2693R1 Formatting thread::id and stacktrace
Feb 21, 2023
burblebee
force-pushed
the
motions-2023-02-lwg-12
branch
from
February 22, 2023 03:28
183caff
to
36452d2
Compare
jensmaurer
reviewed
Feb 22, 2023
JohelEGP
suggested changes
Feb 23, 2023
cpplearner
reviewed
Mar 1, 2023
JohelEGP
approved these changes
Mar 2, 2023
tkoeppe
force-pushed
the
motions-2023-02-lwg-12
branch
from
March 11, 2023 16:21
75cd1e4
to
c8eba48
Compare
Editorial changes: * [thread.thread.id] Follow expressions with "is true". * [stacktrace.format] Employ temporary workaround for library grammar productions and terms as FIXMEs. Fixes NB FR 023 (C++23 CD).
…ad::id, charT> specialization added in P2693R1
tkoeppe
force-pushed
the
motions-2023-02-lwg-12
branch
from
March 11, 2023 17:41
c8eba48
to
5b767b9
Compare
It is [format.string.std] that describes fill-and-align and width.
tkoeppe
force-pushed
the
motions-2023-02-lwg-12
branch
from
March 11, 2023 17:51
23868aa
to
b659879
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[thread.thread.id] Follow expressions with "is true".
Fixes #6102.
Fixes cplusplus/papers#1358
Fixes cplusplus/nbballot#410
Fixes cplusplus/nbballot#414
Please see FIXMEs in code - how to resolve?