Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expected.object.eq] Fix typo #6153

Merged
merged 1 commit into from Mar 12, 2023
Merged

[expected.object.eq] Fix typo #6153

merged 1 commit into from Mar 12, 2023

Conversation

timsong-cpp
Copy link
Contributor

There's no T1 in sight; the relevant template parameter of expected is T.

jwakely
jwakely approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a remnant from P0323R10 (and earlier revisions) which had:

template<class T1, class E1, class T2>
        friend constexpr bool operator==(const expected<T1, E1>&, const T2&);

I corrected the signature for R11 but missed this instance of T1.

@tkoeppe tkoeppe merged commit 9357ba6 into cplusplus:main Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@jwakely jwakely jwakely approved these changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees

@tkoeppe tkoeppe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@timsong-cpp @CaseyCarter @jwakely @jensmaurer @tkoeppe