Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[specialized.algorithms.general] Strike the possibly wrong note #6157

Merged
merged 1 commit into from Mar 12, 2023
Merged

[specialized.algorithms.general] Strike the possibly wrong note #6157

merged 1 commit into from Mar 12, 2023

Conversation

frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Mar 4, 2023 •
edited

Fixes #6143. As discussed in the issue, the note is probably wrong in some cases and we should strike it.

@jensmaurer jensmaurer changed the title [specialized.algorithms.general] Stike the possibly wrong note [specialized.algorithms.general] Strike the possibly wrong note Mar 4, 2023
jensmaurer
jensmaurer approved these changes Mar 4, 2023
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly in favor of fixing the note to use "can". But on the other hand, there are so many things in C++ that "can" yield undefined behavior, so this note probably doesn't deliver enough value overall.

@tkoeppe tkoeppe merged commit 1912644 into cplusplus:main Mar 12, 2023
@frederick-vs-ja frederick-vs-ja deleted the potentially-overlapping branch March 13, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees

@tkoeppe tkoeppe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[specialized.algorithms.general] The note seems incorrect
4 participants
@frederick-vs-ja @CaseyCarter @jensmaurer @tkoeppe