Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expr.prim.req.compound] Move compound requirement example from inner to outer bullet #6159

Merged
merged 2 commits into from Mar 12, 2023
Merged

[expr.prim.req.compound] Move compound requirement example from inner to outer bullet #6159

merged 2 commits into from Mar 12, 2023

Conversation

brevzin
Copy link
Contributor

@brevzin brevzin commented Mar 4, 2023

The example for compound requirement is currently attached to the inner bullet point, but should be attached to the outer one.

@brevzin
Update expressions.tex
3d8f36f 
[This example](http://eel.is/c++draft/expr.prim#req.compound-example-1) is currently attached to the inner bullet point, but should be attached to the outer one.
@brevzin brevzin changed the title Update expressions.tex [expr.prim.req.compound] Move compound requirement from inner to outer bullet Mar 4, 2023
jensmaurer
jensmaurer requested changes Mar 5, 2023
View reviewed changes
source/expressions.tex
@@ -2990,8 +2992,6 @@
\end{codeblock}
(including in the case where $n$ is zero).
\end{example}
\end{itemize}
Copy link
Member

@jensmaurer jensmaurer Mar 5, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're now moving the example to the top level, as opposed to the outer bullet, where it belongs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, one too many \end{itemisze}s that I moved? Changed to just move one.

@jensmaurer
Copy link
Member

Looks good now; the commit description needs to be fixed.

@brevzin
Copy link
Contributor Author

brevzin commented Mar 5, 2023

Looks good now; the commit description needs to be fixed.

To what?

@JohelEGP
Copy link
Contributor

JohelEGP commented Mar 5, 2023

As documented at https://github.com/cplusplus/draft/wiki/Commit-message-format#editorial-commits.

@brevzin brevzin changed the title [expr.prim.req.compound] Move compound requirement from inner to outer bullet [expr.prim.req.compound] Move compound requirement example from inner to outer bullet Mar 5, 2023
@brevzin
Copy link
Contributor Author

brevzin commented Mar 5, 2023

As documented at https://github.com/cplusplus/draft/wiki/Commit-message-format#editorial-commits.

Now that I added the word I was missing, is this already not that?

[expr.prim.req.compound] Move compound requirement example from inner to outer bullet

@JohelEGP
Copy link
Contributor

JohelEGP commented Mar 5, 2023

That's the issue's title. The commit message should be changed accordingly.

@brevzin
Copy link
Contributor Author

brevzin commented Mar 5, 2023

That's the issue's title. The commit message should be changed accordingly.

The PR's title is the commit message if you squash, no?

@tkoeppe tkoeppe merged commit 64ef8b3 into cplusplus:main Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees

@tkoeppe tkoeppe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brevzin @jensmaurer @JohelEGP @tkoeppe