Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring pointer terminology up to date #6174

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

lprv
Copy link
Contributor

@lprv lprv commented Mar 12, 2023

Pointer values are not addresses ([basic.compound]/3), this updates some of the old text to use proper terminology. The intent of the wording is clear, and this PR does not change its normative meaning.

I'm not sure if changing 'address of' to 'pointer representing the address of' is an improvement, so the following are left untouched:

Also, in [temp.arg.nontype]/3, the text should probably also include past-the-end pointers, but that's not editorial.

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 12, 2023

Why is this edtiorial? Unless it is obvious that a change is non-normative (e.g. because it changes a note or example, or fixes a typo), there should be some rationale explaining the intended meaning and why that's unambiguous, and why the change retains that meaning. Otherwise such change requests should probably be CWG issues.

@lprv lprv changed the title [expr.const] Bring pointer terminology up to date Bring pointer terminology up to date Mar 13, 2023
@lprv
Copy link
Contributor Author

lprv commented Mar 13, 2023

Updated with an explanation (and some extra changes).

source/basic.tex Outdated Show resolved Hide resolved
Specifically, in:
 * [expr.prim.lambda.closure]/8, /11
 * [expr.const]/13.3
 * [temp.arg.nontype]/3
@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 16, 2023

@jensmaurer I think some CWG input here would be good, but it seems like a nice improvement.

@tkoeppe tkoeppe added the cwg Issue must be reviewed by CWG. label Aug 16, 2023
@jensmaurer
Copy link
Member

The first part (about lambdas) feels editorial, the other parts fix normative defects and thus should be addressed by a CWG issue.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 11, 2023

CWG meeting consensus Nov 11: good

@tkoeppe tkoeppe removed the cwg Issue must be reviewed by CWG. label Nov 11, 2023
@tkoeppe tkoeppe self-assigned this Nov 11, 2023
@tkoeppe tkoeppe added the after-motions Pull request is to be applied after the pending edits from WG21 straw polls have been applied. label Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
after-motions Pull request is to be applied after the pending edits from WG21 straw polls have been applied.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants