[re.results.general] Add type of match_results::const_iterator to index of imp def behaviour
#6176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndex of imp def The type of most container iterators is records in the index of implementation defined types, but somehow the `match_results` iterator in the <regex> clause was missed. After applying this patch, I grepped for any other occurrences of "\\impdef}" and the only remaining (and intentional) match is the definition of this macro in macros.tex, so there should be no more latent cases to find.
jensmaurer
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of most container iterators is records in the index of implementation defined types, but somehow the
match_resultsiterator in the clause was missed.After applying this patch, I grepped for any other occurrences of "\impdef}" and the only remaining (and intentional) match is the definition of this macro in macros.tex, so there should be no more latent cases to find.