Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fs.conform.9945] Use inter-sentence spacing after an (uppercase) acronym #6180

Merged
merged 1 commit into from Mar 13, 2023

Conversation

morinmorin
Copy link
Contributor

No description provided.

@jensmaurer jensmaurer merged commit bba6c18 into cplusplus:main Mar 13, 2023
2 checks passed
@morinmorin morinmorin deleted the patch-2 branch March 13, 2023 09:49
@morinmorin
Copy link
Contributor Author

Hmm..., grepping with [A-Z]\.\s+\w and a multiline option finds this:

  • compatibility.tex:2307:
    A \keyword{struct} is a scope in \Cpp{}, not in C.
    For example,

  • support.tex:5906:
    one of these headers in order to be valid ISO C.
    Source files that are not intended to also be valid ISO C

  • support.tex:5918:
    The following source file is both valid \Cpp{} and valid ISO C.
    Viewed as \Cpp{}, it declares a function with C language linkage;

  • time.tex:2815:
    The UTC time standard began on 1972-01-01 00:00:10 TAI.
    To measure time since this epoch instead, one can add/subtract the constant

These should be "UPPERCASES\@."

@morinmorin
Copy link
Contributor Author

morinmorin commented Mar 13, 2023

We also need to fix cases like

Let \tcode{i} be an object of type \tcode{I}. When ...

I don't know if these are worth fixing or if \frenchspacing can be a realistic option.

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 13, 2023

Please check first if these actually make a difference to the presentation. I also looked at a couple of such cases where the additional annotations did not affect the visual output.

As far as I can tell, some of these changes make minor differences to the available glue, which may not result in any actual changes.

@morinmorin
Copy link
Contributor Author

Sure, I listed only those that changes the appearance. Here is an output of diff-pdf for the first comment. New (old) text is rendered in cyan (red).
spacing.pdf

@morinmorin
Copy link
Contributor Author

And here is a diff for the second comment. In that comment, I just picked one example of bad spacing, but actually there are TENS of such spacing (i.e. UPPERCASE}. …).
tcode.pdf

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 13, 2023

Could you just post a diffpdf screenshot?

@jensmaurer
Copy link
Member

Example:

Before:

image

After:

image

This looks like an improvement to me.

@jensmaurer
Copy link
Member

I have an automated check; 87 occurrences outstanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants