[container.alloc.reqmts] Better cross-references for allocator-aware … #6189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jwakely, @CaseyCarter Could you please have a look? This looks reasonable to me. |
CaseyCarter
approved these changes
Sep 14, 2023
jwakely
approved these changes
Sep 15, 2023
…containers There are now more allocator-aware containers in the standard than when this subclause was first written, so ensure we have call outs to all relevent subclauses. The current wording for 'basic_stacktrace' also shows how containers can properly call out the allocator-aware container requirements, now they have their own titled subclause.
AlisdairM
force-pushed
the
xref_allocator_aware_containers
branch
from
cd2f30b
to
971abf4
Compare
|
I think I prefer my suggestion over the status quo, even after a night's sleep. |
jwakely
approved these changes
Nov 8, 2023
jensmaurer
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…containers
There are now more allocator-aware containers in the standard than when this subclause was first written, so ensure we have call outs to all relevent subclauses.
The current wording for 'basic_stacktrace' also shows how containers can properly call out the allocator-aware container requirements, now they have their own titled subclause.