[class.ctor.general] Remove the paragraph made dangling by P1787R6 #6195
+0
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
force-pushed
the
unnamed-temp
branch
from
abd1775 to
889ee31
Compare
|
@jensmaurer could you have a look please? |
jensmaurer
requested changes
Mar 29, 2023
jensmaurer
requested changes
Apr 9, 2023
frederick-vs-ja
force-pushed
the
unnamed-temp
branch
from
170c050 to
2cb20d7
Compare
|
Squashed and rebased. |
|
@jensmaurer Could you have another look? |
|
Do we ever care whether an object is "named" or "unnamed"? Entities (such as variables) usually have names, and have associated objects. |
The paragraph was made dangling by P1787R6.
frederick-vs-ja
force-pushed
the
unnamed-temp
branch
from
2cb20d7 to
85849e1
Compare
|
I'm now completely removing the note and associated index. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While "this way" is in normative wording, the referred way is moved into a non-normative note by P1787R6 (#[class.ctor]). It's probably wrong for nomative wording to do this.
Additionally, the paragraph seems already incorrect in C++17, because
auto s = std::string();seemly creates a named object in "this way". Temporary objects created in this way are unnamed, but I believe it makes more sense to say all temporary objects are unnamed.Fixes #5491.