New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent double spacing in tcode #6200
Conversation
Defining
However, |
1558bac
to
682aaef
Compare
This now has overfull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix overfull lines per "check-output.sh" results.
In `\nofrenchspacing`, a space after `.`, `?`, `!`, `:` are rendered as two spaces in monospaced fonts if these punctuations are preceded by non-capital characters. This can be fixed by adding `\frenchspacing` to `CodeStylex`.
afc8c88
to
cf2e4ef
Compare
Thanks for the guidance. There are three overfull boxes.
The global macro |
For the first transgression, can you add a hyphenation hint iterator_catego-ry instead? Usually, the spaces are already very compressed when you get an overfull \hbox warning, and we regularly hyphenate this \tcode words if necessary. |
For the first transgression, the offending part is the The only viable hyphen-hint is |
cf2e4ef
to
d826108
Compare
I took this route:
The issue is resolved now, I think. |
@tkoeppe, this looks like an editorial improvement. |
@jensmaurer Yes, I agree. Any final thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tkoeppe, all good.
Due to
nofrenchspacing
, a space after.
,:
,?
are rendered as two spaces in monospaced fonts if these punctuations are preceded by non-capital characters. For example,\tcode{a ? b : c}
is rendered asa ? b : c
, andis rendered as
Currently, there are tens of these double spacings in the Standard.
This PR prevents them by adding
\frenchspacing
toCodeStylex
.