Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump value of __cpp_lib_allocate_at_least for C++23 #6202

Closed
jwakely opened this issue Mar 22, 2023 · 4 comments · Fixed by #6205
Closed

Bump value of __cpp_lib_allocate_at_least for C++23 #6202

jwakely opened this issue Mar 22, 2023 · 4 comments · Fixed by #6205

Comments

@jwakely
Copy link
Member

jwakely commented Mar 22, 2023

LWG 3887 wants to increase the value of the __cpp_lib_allocate_at_least macro to distinguish the pre-P2652R0 API from the new one that will be in C++23. LWG voted this Tentatively Ready, but if we follow the usual process that will be approved in Varna, for C++26. There's not much point updating it if we only do so for C++26.

I think it can be argued that the value of the macro in the standard is editorial. The standard doesn't say what a given value means, only SD-6 does that.

Would the editor please consider giving the value 202302L to __cpp_lib_allocate_at_least, and we'll get @brevzin to update SD-6?

@jwakely
Copy link
Member Author

jwakely commented Mar 23, 2023

@phalpern - as the author of P2652 please indicate your support (or not) for this.

@brevzin
Copy link
Contributor

brevzin commented Mar 23, 2023

Yep, this is a good idea 👍 . We've also done this with other papers in the past too.

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 23, 2023

That seems reasonable! Could you please send a PR? We will land that in the next draft, together with the review committee feedback.

jwakely added a commit to jwakely/draft that referenced this issue Mar 23, 2023
This is requested for the Tentatively Ready LWG issue 3887.

Fixes cplusplus#6202
@phalpern
Copy link

phalpern commented Mar 23, 2023 via email

jwakely added a commit to jwakely/draft that referenced this issue Mar 23, 2023
This is requested for the Tentatively Ready LWG issue 3887.

Fixes cplusplus#6202
tkoeppe pushed a commit that referenced this issue Mar 23, 2023
This is requested for the Tentatively Ready LWG issue 3887.

Fixes #6202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants