Mac modernization: allow listings 1.9, and don't allow errors in a pipe #6206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkoeppe
changed the title
tkoeppe
commented
Mar 23, 2023
This check breaks every time there is a new version, and is perhaps not pulling its weight.
The MacOS shell does not seem to tolerate a failure of the first part of the "make quiet" pipe.
tkoeppe
commented
Mar 23, 2023
| run: make quiet | ||
|
|
||
| - name: make (MacOS) | ||
| if: matrix.cfg.os == 'macos-12' | ||
| run: make full |
There was a problem hiding this comment.
So, this one is weird: the || in the Makefile seems to not work on MacOS anymore.
There was a problem hiding this comment.
Nothing is needed, but it's an odd change of behaviour, which I imagine should show up elsewhere... but I think we can live with it.
There was a problem hiding this comment.
The default shell changed from bash to zsh in modern macOS versions, but that shouldn't matter. It seems more likely that the behaviour of latexmk changed so that -silent causes it to exit with status 0 even if the build failed.
There was a problem hiding this comment.
Ohh, that's interesting! That means we'll see the same on Linux when that version changes, I expect!
jensmaurer
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jensmaurer We need to allow listings 1.9 for MacOS. Is there any point in having the version check at all?