[container.opt.reqmts] Index 3-way compare for containers #6220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the standard containers are 3-way comparable, but the specification is provided under optional container requirements so does not show up in the index. Adding these links shows just how poorly indexed the members of the 'flat_*' container adapters are, but that is properly the business on a separate PR.
JohelEGP
suggested changes
Apr 4, 2023
Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
This form seems a closer match to how the other container requirements operations are indexed, where we get just one generic entry in the index for "optional container requirements" and a specific entry for the operator on each listed container.
|
I think we now have two options: the original version of the PR, or the current state where I use a local macro to index all operations with a grouped text-name, while retaining the correct indexing in each container. @tkoeppe @jensmaurer @jwakely could you express a preference? |
JohelEGP
suggested changes
Apr 4, 2023
Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
|
The current state with |
|
@jwakely Any thoughts? |
jwakely
reviewed
Nov 8, 2023
Co-authored-by: Jonathan Wakely <github@kayari.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the standard containers are 3-way comparable, but the specification is provided under optional container requirements so does not show up in the index.
Adding these links shows just how poorly indexed the members of the 'flat_*' container adapters are, but that is properly the business on a separate PR.