[expr.shift] more precise wording for arithmetic shift rounding CWG2724 #6225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eisenwave
changed the title
|
I've noticed this needs a fixed commit message when merging. |
|
Thanks for raising this, but I think this should be treated as a library issue, and not editorially. Could you please file one? |
|
@tkoeppe, why would this be a library issue? It's certainly affecting CWG wording. |
|
@Eisenwave , if you want your real name to appear in the core issue, please either change your github settings or send it to me via e-mail. |
jensmaurer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems with the present wording
is sometimes used to describe rounding towards zero, and sometimes to describe rounding towards negative infinity. For example, Java uses java.math.RoundingMode.DOWN to describe rounding towards zero.
It is intuitively clear to the committee and to implementers that this should mirror the semantics of the "arithmetic right shift" instruction (which rounds towards negative infinity), but the wording is not so clear.
Improvements made by the suggested wording
is unambiguous.
The wording is also quite popular, e.g. the Wikipedia article on rounding uses it.