Fix Subclause name for cstddef in headers.cpp.fs #6227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
approved these changes
Apr 9, 2023
There was a problem hiding this comment.
This seems to be an obviously-correct improvement.
@tkoeppe, when merging, fix the commit description. Referring to table numbers is unstable.
|
@winspool, if you want your full name to appear in the commit history, please adjust your github settings accordingly. Feel free to force-push afterwards. |
The new name "Common definitions" for the section 17.2 entry in Table "headers.cpp.fs" is already used as name for the section 17.2 entry in Table "support.summary" and is also used as the section name in section 17.2 "support.types" -- Regards ... Detlef Riekenberg
|
I replaced the Table numbers with the Table names in the commit message -- |
|
What can i do to get the fix commited? -- |
|
Sorry for the delay, and thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new name "Common definitions" for the entry of section 17.2 in Table headers.cpp.fs
is already used as name for the entry of section 17.2 in Table support.summary
and is also used as the name in section 17.2 (support.types)
There is still a difference for cstdlib (17.2.2: cstdlib.syn):
Table "support.summary" lists cstdlib for entry 17.2 and entry 17.5, but
Table "headers.cpp.fs" lists cstdlib only for entry 17.5.
According to the Text in 17.2.2, cstdlib has 2 freestanding entries related to section 17.2
and 5 freestanding entries related to section 17.5.
cstdlib has references to a lot more sections, which are not listed in Table "support.summary",
but adding every reference from cstdlib to Table "support.summary" makes the Table very ugly.
--
Regards ... Detlef Riekenberg