Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update action in GitHub workflow #6231

Merged
merged 1 commit into from Apr 21, 2023
Merged

tools: update action in GitHub workflow #6231

merged 1 commit into from Apr 21, 2023

Conversation

VoltrexKeyva
Copy link
Contributor

Update the actions/upload-artifact action to version 3.

@VoltrexKeyva
tools: update action in GitHub workflow
35577a2 
Update the `actions/upload-artifact` action to version 3.
jwakely
jwakely reviewed Apr 12, 2023
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any particular reason to update, other than it being the latest?

@VoltrexKeyva
Copy link
Contributor Author

Is there any particular reason to update, other than it being the latest?

Version 2 of that action uses the deprecated set-output command in the GitHub Actions which'll be removed soon enough.

@tkoeppe
Copy link
Contributor

tkoeppe commented Apr 13, 2023

Thanks, that seems reasonable!

@VoltrexKeyva
Copy link
Contributor Author

Can this be merged? Anything left to do?

@tkoeppe
Copy link
Contributor

tkoeppe commented Apr 21, 2023

No, I think it's fine, thanks!

@tkoeppe tkoeppe merged commit 44ff7aa into cplusplus:main Apr 21, 2023
2 checks passed
@VoltrexKeyva VoltrexKeyva deleted the update-action branch April 21, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely left review comments

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees

@tkoeppe tkoeppe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@VoltrexKeyva @tkoeppe @jwakely @jensmaurer