Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One \grammarterm{x}, two \grammarterm{x}{s} (and likewise) #6235

Closed
wants to merge 2 commits into from

Conversation

adr26
Copy link
Contributor

@adr26 adr26 commented Apr 19, 2023

There was inconsistent use of grouping after \grammarterm, \tcode, \keyword, etc.

Update plurals to consistently use {s}/{es} after these.

Also fix a missing apostrophe in [dcl.init.aggr]/16, example 11.

@tkoeppe
Copy link
Contributor

tkoeppe commented May 12, 2023

Hm, I'm not sure what the benefit of these changes is, or if there is any valuable notion of consistency at stake here. I'll happily take the missing apostrophe fix, but the rest seems to lack motivation. In particular, I don't think \tcode{foo}{s} is a useful spelling, compared to \tcode{foo}s.

@tkoeppe tkoeppe closed this May 12, 2023
@jensmaurer
Copy link
Member

Once upon a time, there was a spacing problem with the\grammarterm macro that required the trailing {s} to avoid bad behavior. The spacing problem has been fixed, and we should gravitate towards plain s.

@adr26
Copy link
Contributor Author

adr26 commented May 12, 2023

Once upon a time, there was a spacing problem with the\grammarterm macro that required the trailing {s} to avoid bad behavior. The spacing problem has been fixed, and we should gravitate towards plain s.

I was worried about that, given the lack of consistency I'd spotted. If the spacing problem has been fixed, do you think it would be worth doing the reverse of the original changes and change {s} -> s throughout?

If the spacing problem is fixed, you could make the argument it was unnecessary change, but consistency is a virtue in its own right... I am happy to be guided and either leave this as-is, or open a new PR, depending on your thoughts.

Thanks for getting back to me,

Andrew R

@tkoeppe
Copy link
Contributor

tkoeppe commented May 12, 2023

I see neither a defect nor any value in changing anything here.

If you have spare time, we could definitely use some help in either triaging issues, or in adopting orphaned, old pull requests!

@JohelEGP
Copy link
Contributor

JohelEGP commented Jun 21, 2023

Once upon a time, there was a spacing problem with the\grammarterm macro that required the trailing {s} to avoid bad behavior. The spacing problem has been fixed, and we should gravitate towards plain s.

Is that still the case for {'s}?
74d1e7a introduces some of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants