Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[defns.iostream.templates] This section doesn't seem helpful and may be misleading #6236

Closed
frederick-vs-ja opened this issue Apr 21, 2023 · 4 comments
Closed

[defns.iostream.templates] This section doesn't seem helpful and may be misleading #6236

frederick-vs-ja opened this issue Apr 21, 2023 · 4 comments

Comments

@frederick-vs-ja
Copy link
Contributor

It seems that [defns.iostream.templates] is not referenced elsewhere in the standard. And perhaps it's wrong to exclude basic_stringbuf and basic_syncbuf (and their friends).

Should we just remove this section?
@jwakely
Copy link
Member

jwakely commented Apr 21, 2023 •
edited

See [defns.character.container]. In C++98 and C++03 that said "It is used for one of the template parameters of the
string and iostream class templates." In C++11 it was changed to a note talking about "the string, iostream, and regular expression class templates".

So it's still used, but as "the string [class templates], iostream [class templates], and regular expression class templates". I don't think anybody will actually make the connection between that note and the definition though.

I think it would be OK to remove it, but maybe we should improve the note in [defns.character.container] to be more clear about what "string, iostream, and regular expression class templates" refers to. Maybe change it to:

It is used for the template parameters of std::char_traits and the class templates that use that, such as the string, iostream, and regular expression class templates.

@frederick-vs-ja frederick-vs-ja mentioned this issue Oct 7, 2023
Merged
@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 10, 2023

@jwakely Can you send a PR with that change?

jwakely added a commit to jwakely/draft that referenced this issue Nov 8, 2023
@jwakely
[defns.character.container] Improve note
d3e1e3b 
Relates: cplusplus#6236
@jwakely jwakely mentioned this issue Nov 8, 2023
Merged
@jwakely
Copy link
Member

jwakely commented Nov 8, 2023

@jwakely Can you send a PR with that change?

as-you-wish.gif

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 9, 2023

The unhelpful section is no more.

@tkoeppe tkoeppe closed this as completed Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jwakely @tkoeppe @frederick-vs-ja