Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[container.alloc.reqmts] Fix incorrect change of \mandates to \expects #6244

Merged
merged 1 commit into from May 5, 2023

Conversation

jwakely
Copy link
Member

@jwakely jwakely commented May 5, 2023

This was incorrectly changed from a \mandates to an \expects when 93ff092 replaced the requirements tables.

93ff092#diff-3b5851f7056b7c68cb3ba2ab51cf0b75a780c6a11e5e181770067700454ace7bL734 (click on "Load diff") shows the previous state, with \mandates, and 93ff092#diff-3b5851f7056b7c68cb3ba2ab51cf0b75a780c6a11e5e181770067700454ace7bR1005 shows the new state, with \expects. That change was supposed to be editorial, but this is a normative change.

This was incorrectly changed from a \mandates to an \expects when
93ff092 replaced the requirements
tables.
jwakely referenced this pull request May 5, 2023
and adjust cross-references to container requirements tables
throughout the standard library.
@jwakely
Copy link
Member Author

jwakely commented May 5, 2023

It looks like that was the only \mandates in the container requirements tables, and the only one removed by the commit.

@tkoeppe
Copy link
Contributor

tkoeppe commented May 5, 2023

Thanks a lot for spotting this!

@tkoeppe tkoeppe merged commit b81e4be into cplusplus:main May 5, 2023
2 checks passed
@jwakely jwakely deleted the cont-alloc-reqs-mandates branch May 5, 2023 11:21
@jwakely
Copy link
Member Author

jwakely commented May 5, 2023

Thanks to @Dani-Hub for pointing out that the current draft said Preconditions there.

@tkoeppe
Copy link
Contributor

tkoeppe commented May 5, 2023

Nothing escapes the watchful eye of @Dani-Hub -- thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants