Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ranges] Make the "Effects: Equivalent to" format consistent #6254

Merged
merged 1 commit into from Jul 23, 2023
Merged

[ranges] Make the "Effects: Equivalent to" format consistent #6254

merged 1 commit into from Jul 23, 2023

Conversation

hewillk
Copy link
Contributor

@hewillk hewillk commented May 17, 2023

  • When "Effects: Equivalent to" is followed by a " ", the subsequent expression ends with a ".";
  • When "Effects: Equivalent to" is followed by a ":", the subsequent expression ends with a ";".

@JohelEGP
Copy link
Contributor

See https://github.com/cplusplus/draft/wiki/Specification-Style-Guidelines#writing-effects-in-a-function-description for the specifics.
It's actually about expression vs. statement.

@hewillk
Copy link
Contributor Author

hewillk commented May 17, 2023

[input.output] also has this inconsistency problem, and I will fix that with a new PR.

@JohelEGP
Copy link
Contributor

It's actually about expression vs. statement.

For these particular cases.
: is also required before code blocks.

@tkoeppe tkoeppe merged commit 56a6b7f into cplusplus:main Jul 23, 2023
2 checks passed
@hewillk hewillk deleted the main-return branch July 23, 2023 01:27
@hewillk hewillk mentioned this pull request Jul 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohelEGP JohelEGP JohelEGP approved these changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees

@tkoeppe tkoeppe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hewillk @JohelEGP @jensmaurer @tkoeppe