Fix remaining references to container requirements, and adjust subclause naming #6255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For [re.results.general], would it be better to say
instead of:
? |
|
That would be consistent with [stacktrace.basic.overview], which says:
|
jwakely
changed the title
tkoeppe
reviewed
Jun 13, 2023
…ements.general] These should refer to [container.alloc.reqmts] for an allocator-aware container.
There are no more cross-references to [container.gen.reqmts] or [container.requirements.general], so this doesn't affect anything else.
tkoeppe
force-pushed
the
issue-6184
branch
2 times, most recently
from
2f9b1b4
to
dd32b7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6184
I missed the [re.results.general] one in #6253 because I searched for
{container.requirements.general}. The [string.cons] one is to the top-level of container requirements, but should be to the sequence requirements.After fixing those, we can retitle/relabel some of the container requirements subclauses, as discussed in #6184