[flat.multiset.defn] Fix minor errors and inconsistencies #6260
Conversation
[flat.set.defn] and [flat.multiset.defn] are now formatted identically. Additionally removed erroenous template parameters in two deduction guides.
|
@jwakely, @CaseyCarter could you kindly take a look? |
| -> flat_multiset<@\placeholder{iter-value-type}@<InputIterator>, @\placeholder{iter-value-type}@<InputIterator>, Compare>; | ||
| -> flat_multiset<@\placeholder{iter-value-type}@<InputIterator>, Compare>; | ||
|
|
||
| template<class InputIterator, class Compare = less<@\placeholder{iter-value-type}@<InputIterator>>> | ||
| flat_multiset(sorted_equivalent_t, InputIterator, InputIterator, Compare = Compare()) | ||
| -> flat_multiset<@\placeholder{iter-value-type}@<InputIterator>, @\placeholder{iter-value-type}@<InputIterator>, Compare>; | ||
| -> flat_multiset<@\placeholder{iter-value-type}@<InputIterator>, Compare>; |
There was a problem hiding this comment.
This corrects (what to me is) obvious copy-pasta from flat_multimap. I call it "editorial" despite that it's a borderline normative change.
| @@ -17163,7 +17163,7 @@ | |||
| const key_compare& comp = key_compare()) | |||
| : @\exposid{c}@(std::move(cont)), @\exposid{compare}@(comp) { } | |||
| template<class Allocator> | |||
| flat_multiset(sorted_equivalent_t, const container_type&, const Allocator& a); | |||
| flat_multiset(sorted_equivalent_t, const container_type& cont, const Allocator& a); | |||
There was a problem hiding this comment.
This agrees with the form of the redeclaration in [flat.multiset.cons], as is consistent with LWG style.
| container_type @\exposid{c}@; // \expos | ||
| key_compare @\exposid{compare}@; // \expos |
There was a problem hiding this comment.
I refuse to learn the editorial "rules" for comments, so someone else needs to sign off on these two (obivously editorial) lines.
There was a problem hiding this comment.
While the rules superficially only concern the source code column of the comment, there are subtleties about italic correction here, too, and you shall not be blamed for not participating in those deliberations :-)
|
Thank you, both, and also @Saalvage for the PR! |
|
Applied as aa8a531, thanks! |
[flat.set.defn] and [flat.multiset.defn] are now formatted identically.
Additionally removed erroneous template parameters in two deduction guides (the
Keywas provided twice).CC: @tzlaine