Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mdspan.mdspan.cons] OtherIndexType is not a parameter pack ([mdspan.mdspan.cons]/8.2) #6263

Merged
merged 2 commits into from Jul 24, 2023
Merged

[mdspan.mdspan.cons] OtherIndexType is not a parameter pack ([mdspan.mdspan.cons]/8.2) #6263

merged 2 commits into from Jul 24, 2023

Conversation

JMazurkiewicz
Copy link
Contributor

No description provided.

@jwakely
Copy link
Member

jwakely commented May 30, 2023

Even if it were a pack, this would be wrong because it would need to use is_nothrow_constructible_v instead.

@tkoeppe
Copy link
Contributor

tkoeppe commented Jul 23, 2023

Aren't we missing the _v in any case? @jwakely?

@jwakely
Copy link
Member

jwakely commented Jul 24, 2023

Yes indeed - not sure how I missed that despite commenting on it 🤦

@tkoeppe
Copy link
Contributor

tkoeppe commented Jul 24, 2023

@jwakely PTAL, like so?

@tkoeppe tkoeppe merged commit 84cf8ef into cplusplus:main Jul 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JMazurkiewicz @jwakely @tkoeppe