Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expr.add] Clarify note on pointer subtraction #6269

Merged
merged 1 commit into from Jul 23, 2023

Conversation

vasama
Copy link
Contributor

@vasama vasama commented Jun 7, 2023

Fixes #6268.

No changes to normative wording.

@jensmaurer
Copy link
Member

@vasama, if you want to have your real name show up in the commit history, please configure it in the github settings.

@vasama
Copy link
Contributor Author

vasama commented Jun 8, 2023

I set my name on my GitHub profile, but if it's just for the sake of vanity and would require recreating the commit, then don't worry about it.

@jensmaurer
Copy link
Member

@vasama, that's enough. When squash-merging your commit, github will put in your real name in the "new" commit.

@jensmaurer
Copy link
Member

@tkoeppe , this moves a note one bullet up to better fit the context.

@tkoeppe tkoeppe merged commit a34d2e0 into cplusplus:main Jul 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[expr.add] Pointer subtraction when P-Q is out of range of ptrdiff_t is unclear
3 participants