Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[meta.trans.other] Table 57 uses the layout for type predicates (Tables 47-49,51) instead of type transformations/queries (Tables 50,52-56) #629

Closed
cubbimew opened this issue Mar 3, 2016 · 1 comment
Closed

[meta.trans.other] Table 57 uses the layout for type predicates (Tables 47-49,51) instead of type transformations/queries (Tables 50,52-56) #629

cubbimew opened this issue Mar 3, 2016 · 1 comment

Comments

@cubbimew
Copy link
Contributor

cubbimew commented Mar 3, 2016

Table 57 "Other transformations" in 20.10.7.6[meta.trans.other] has three columns named "Template", "Condition", "Comments", which is how predicate tables (Table 47,48,49,51) are laid out. However, the traits listed in Table 57 are not predicates and do not test any condition. These are transformation traits, and the rest of those traits use two-column layout "Template", "Comments" (Tables 50,52,53,54,55,56)
The contents of the column named "Condition" in Table 57 where not empty appear to be the requirements on the template type parameters, which means they should move into Comments after the word "Requires:" as done for other transformation traits, namely in Tables 50 and 54
AlisdairM added a commit to AlisdairM/draft that referenced this issue Jun 10, 2016
@AlisdairM
[meta.trans.other] Reformat Other Transformations table
71e4f87 
This PR applies the change recommended by cplusplus#629.

So far, I like the change giving the descriptions more room to
breathe, but for come reason the first column has become a
little narrower, which is messing with the format a little.

Generally, I think this looks like a good fix, but may use a
little more polish to get the presentation just right.
@AlisdairM AlisdairM mentioned this issue Jun 10, 2016
Closed
jwakely pushed a commit that referenced this issue Jun 22, 2016
@AlisdairM @jwakely
[meta.trans.other] Reformat Other Transformations table
863cbd1 
This PR applies the change recommended by #629.

So far, I like the change giving the descriptions more room to
breathe, but for come reason the first column has become a
little narrower, which is messing with the format a little.

Generally, I think this looks like a good fix, but may use a
little more polish to get the presentation just right.
@jwakely
Copy link
Member

jwakely commented Jun 22, 2016

Fixed by #747

@jwakely jwakely closed this as completed Jun 22, 2016
FrankHB pushed a commit to FrankHB/draft that referenced this issue Jul 9, 2016
@AlisdairM @FrankHB
[meta.trans.other] Reformat Other Transformations table
5657071 
This PR applies the change recommended by cplusplus#629.

So far, I like the change giving the descriptions more room to
breathe, but for come reason the first column has become a
little narrower, which is messing with the format a little.

Generally, I think this looks like a good fix, but may use a
little more polish to get the presentation just right.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwakely @cubbimew