Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LWG 29] P2630R4 submdspan #6338

Merged
merged 8 commits into from Jul 22, 2023
Merged

[LWG 29] P2630R4 submdspan #6338

merged 8 commits into from Jul 22, 2023

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Jun 22, 2023 •
edited by jensmaurer

@burblebee burblebee marked this pull request as ready for review June 22, 2023 18:06
JohelEGP
JohelEGP suggested changes Jun 23, 2023
View reviewed changes
source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated
\effects
Equivalent to:
\begin{codeblock}
auto sub_map_offset = submdspan_mapping(src.mapping(), args...);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, so you're telling me we don't really need
the last item of \mandates and
the first item of \expects?
It's subsumed by the "Effects: Equivalent to:" semantics.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could send a PR for this; sounds like a nice simplification.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #6399 for this.

source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
@JohelEGP JohelEGP mentioned this pull request Jun 25, 2023
Open
@jensmaurer jensmaurer added this to the post-2023-06 milestone Jun 27, 2023
@burblebee burblebee marked this pull request as draft June 29, 2023 03:40
@burblebee
Copy link
Contributor Author

The builds are failing during the system install - who maintains the build machines?

@burblebee burblebee marked this pull request as ready for review June 29, 2023 05:29
@burblebee burblebee requested a review from JohelEGP June 29, 2023 05:29
JohelEGP
JohelEGP suggested changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some "otherwise" left to be moved to the beginning of the next list item (as per #5810).
I didn't add suggestion for those, before or now, because they're a bit more involved.

Still open comments:

Opened #6365 with regards to rank.

source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
@burblebee burblebee requested a review from JohelEGP July 2, 2023 17:57
@tkoeppe tkoeppe force-pushed the motions-2023-06-lwg-29 branch 2 times, most recently from e9f55fa to 4cc3622 Compare July 21, 2023 22:58
tkoeppe
tkoeppe reviewed Jul 21, 2023
View reviewed changes
source/containers.tex Outdated Show resolved Hide resolved
@tkoeppe tkoeppe force-pushed the motions-2023-06-lwg-29 branch 2 times, most recently from 9dd51d6 to f5620ae Compare July 22, 2023 22:46
tkoeppe
tkoeppe reviewed Jul 22, 2023
View reviewed changes
source/containers.tex
\begin{itemize}
\item $S_k$ models \tcode{\libconcept{convertible_to}<IndexType>},
\item $S_k$ models \tcode{\exposconcept{index-pair-like}<IndexType>},
\item \tcode{is_convertible_v<$S_k$, full_extent_t>} is \tcode{true}, or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is full_extent_t defined?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #6353 for this.
P0009 (R18) mentions in "1.8 P0009r11: 2021-05 Mailing"

Renamed all_type to full_extent_t and all to full_extent

My guess is that submdspan wasn't up to date.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crtrott ^^^ ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks for the issue! We can defer that if there's no immediate solution at hand.

burblebee and others added 8 commits July 23, 2023 00:30
@burblebee @tkoeppe
P2630R4 submdspan
008addc 
Editorial notes:
- [mdspan.submdspan.submdspan] Fix typo: "args" should say "slices".
- [mdspan.submdspan.overview] Change "subsection" to "subclause".
- [mdspan.submdspan.extents] Fix comma placement.
- [mdspan.submdspan.extents] "for each" instead of "for all".
- [mdspan.submdspan.submdspan, mdspan.syn] Fix cross-reference.
- [mdspan.submdspan.submdspan] Fix punctuation in itemized list.
@burblebee @tkoeppe
[mdspan.submdspan.*] Fix punctuation in itemized lists; use ", or".
4e4795e
@burblebee @tkoeppe
[mdspan.submdspan.submdspan] Rename section to "submdspan template fu…
272a009 
…nction"
@burblebee @tkoeppe
[mdspan.submdspan.*] Change "Let .. name the type" to "Let ... be" fo…
08803e9 
…r consistency
@burblebee @tkoeppe
[mdspan.submdspan.*] Use \codeblocks instead of \itemdecl/descrs for …
1051ee4 
…definitions of structs strided_slice and submdspan_mapping_result
@burblebee @tkoeppe
[mdspan.submdspan.*] Move "otherwise" to front of itemized lists.
8e22404
@tkoeppe
[mdspan.syn, mdspan.submdspan.submdspan] Rename "template function" t…
cd1eb06 
…o "function template"
@tkoeppe
[mdspan.submdspan.strided.slice] Use member typedefs instead of templ…
75ed240 
…ate arguments
@tkoeppe tkoeppe mentioned this pull request Jul 22, 2023
Open
@tkoeppe tkoeppe merged commit 5fccb90 into main Jul 22, 2023
4 checks passed
@JohelEGP JohelEGP mentioned this pull request Jul 23, 2023
Open
@jensmaurer jensmaurer deleted the motions-2023-06-lwg-29 branch November 12, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoeppe tkoeppe tkoeppe left review comments

@JohelEGP JohelEGP JohelEGP approved these changes

@jensmaurer jensmaurer jensmaurer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2023-06
Development

Successfully merging this pull request may close these issues.

[2023-06 LWG Motion 29] P2630R4 submdspan P2630 R4 Submdspan
4 participants
@burblebee @tkoeppe @JohelEGP @jensmaurer