Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LWG motion 25] P1383R2 More constexpr for cmath and complex #6343

Merged
merged 2 commits into from Jul 21, 2023
Merged

[LWG motion 25] P1383R2 More constexpr for cmath and complex #6343

merged 2 commits into from Jul 21, 2023

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Jun 22, 2023 •
edited by jensmaurer

@burblebee burblebee marked this pull request as ready for review June 23, 2023 00:07
JohelEGP
JohelEGP approved these changes Jun 24, 2023
View reviewed changes
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using https://isocpp.org/files/papers/P1383R2.pdf.

@jensmaurer jensmaurer added this to the post-2023-06 milestone Jun 27, 2023
@PJBoy
Copy link
Contributor

PJBoy commented Jun 28, 2023

No feature test macro?

@JohelEGP
Copy link
Contributor

Looks like __cpp_lib_constexpr_cmath wasn't bumped by the paper.

@PJBoy
Copy link
Contributor

PJBoy commented Jun 28, 2023

Shall we let burblebee commit a bump as part of this PR or should I raise a new issue?

@jwakely
Copy link
Member

jwakely commented Jun 28, 2023

LWG motion 5 was missing a macro bump too

@jensmaurer
Copy link
Member

@burblebee , please bump __cpp_lib_constexpr_cmath in a separate commit of this pull request.

@tkoeppe
Copy link
Contributor

tkoeppe commented Jul 21, 2023

Feature test macro bumped, thanks!

@tkoeppe tkoeppe merged commit 77cd5e1 into main Jul 21, 2023
4 checks passed
@JohelEGP JohelEGP mentioned this pull request Jul 28, 2023
Merged
@jensmaurer jensmaurer deleted the motions-2023-06-lwg-25 branch November 12, 2023 21:27
@StephanTLavavej StephanTLavavej mentioned this pull request Mar 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohelEGP JohelEGP JohelEGP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2023-06
6 participants
@burblebee @PJBoy @JohelEGP @jwakely @jensmaurer @tkoeppe