Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LWG motion 21] P2637R3 Member visit #6350

Merged
merged 1 commit into from Jul 21, 2023
Merged

[LWG motion 21] P2637R3 Member visit #6350

merged 1 commit into from Jul 21, 2023

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Jun 24, 2023 •
edited by jensmaurer

Fixes #6307.
Fixes cplusplus/papers#1303

Notes/questions:

  • Is there any order to the sections in [depr]?

@burblebee burblebee marked this pull request as ready for review June 24, 2023 00:31
@JohelEGP
Copy link
Contributor

JohelEGP commented Jun 25, 2023 •
edited

Is there any order to the sections in [depr]?

Considering the introduction,
I'd hope it mimics the main text.
1687704178

Actually, that's for the previous standard.

JohelEGP
JohelEGP suggested changes Jun 25, 2023
View reviewed changes
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using https://isocpp.org/files/papers/P2637R3.html.

I think you need to add some \movedxrefs to xrefdelta.tex.

3.1 wasn't applied.

@jensmaurer jensmaurer added this to the post-2023-06 milestone Jun 27, 2023
@burblebee
Copy link
Contributor Author

I think you need to add some \movedxrefs to xrefdelta.tex.

Don't see where that's needed; don't see any moved sections.

3.1 wasn't applied.

Applied missed edit 3.1, thanks!

@burblebee burblebee requested a review from JohelEGP June 28, 2023 01:44
@tkoeppe tkoeppe merged commit 04cf6ed into main Jul 21, 2023
4 checks passed
@jensmaurer jensmaurer deleted the motions-2023-06-lwg-21 branch November 12, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter left review comments

@tkoeppe tkoeppe tkoeppe left review comments

@JohelEGP JohelEGP JohelEGP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2023-06
Development

Successfully merging this pull request may close these issues.

[2023-06 LWG Motion 21] P2637R3 Member visit P2637 R3 Member visit
5 participants
@burblebee @JohelEGP @CaseyCarter @tkoeppe @jensmaurer