Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LWG motion 17] P1885R12 Naming Text Encodings to Demystify Them #6359

Merged
merged 3 commits into from Jul 21, 2023
Merged

[LWG motion 17] P1885R12 Naming Text Encodings to Demystify Them #6359

merged 3 commits into from Jul 21, 2023

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Jun 27, 2023 •
edited by jensmaurer

[text.*] Minor changes were made for consistency with existing text.

Fixes #6303.
Fixes cplusplus/papers#634

Edit notes:

  • How to specify the references in the Bibliography?

@burblebee burblebee force-pushed the motions-2023-06-lwg-17 branch 3 times, most recently from 13ddad0 to 6f102a7 Compare June 27, 2023 21:47
@burblebee burblebee marked this pull request as ready for review June 27, 2023 21:54
@jensmaurer jensmaurer added this to the post-2023-06 milestone Jun 27, 2023
jensmaurer
jensmaurer requested changes Jun 28, 2023
View reviewed changes
source/locales.tex Outdated Show resolved Hide resolved
source/intro.tex Outdated Show resolved Hide resolved
source/locales.tex Outdated Show resolved Hide resolved
source/locales.tex Show resolved Hide resolved
source/locales.tex Outdated Show resolved Hide resolved
source/locales.tex Outdated Show resolved Hide resolved
source/locales.tex Outdated Show resolved Hide resolved
source/locales.tex Outdated Show resolved Hide resolved
source/locales.tex Outdated Show resolved Hide resolved
source/locales.tex Outdated Show resolved Hide resolved
@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Jun 28, 2023
@burblebee
Copy link
Contributor Author

The build machines are failing during the install process.

jensmaurer
jensmaurer previously requested changes Jun 29, 2023
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little more needed.

source/back.tex Show resolved Hide resolved
source/locales.tex Outdated Show resolved Hide resolved
JohelEGP
JohelEGP suggested changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we were to follow [ranges],
[text.encoding.aliases] would come after
[text.encoding.comp]/[text.encoding.cmp].

source/locales.tex Outdated Show resolved Hide resolved
source/locales.tex Outdated Show resolved Hide resolved
source/locales.tex Outdated Show resolved Hide resolved
source/locales.tex Outdated Show resolved Hide resolved
source/locales.tex Outdated Show resolved Hide resolved
source/locales.tex Outdated Show resolved Hide resolved
source/locales.tex Outdated Show resolved Hide resolved
source/locales.tex Show resolved Hide resolved
source/locales.tex Outdated Show resolved Hide resolved
source/locales.tex Outdated Show resolved Hide resolved
@burblebee burblebee marked this pull request as draft July 2, 2023 18:45
@burblebee burblebee requested a review from JohelEGP July 4, 2023 19:44
@burblebee burblebee marked this pull request as ready for review July 4, 2023 19:46
JohelEGP
JohelEGP suggested changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments were not applied:

source/locales.tex Outdated Show resolved Hide resolved
source/locales.tex Outdated Show resolved Hide resolved
@burblebee
Copy link
Contributor Author

If we were to follow [ranges], [text.encoding.aliases] would come after [text.encoding.comp]/[text.encoding.cmp].

If I were to make that change now it would complicate matters for Thomas when he tries to apply the additional commits. @tkoeppe, maybe you can make this change afterwards?

@burblebee burblebee requested a review from JohelEGP July 5, 2023 21:24
@tkoeppe
Copy link
Contributor

tkoeppe commented Jul 21, 2023

If we were to follow [ranges], [text.encoding.aliases] would come after [text.encoding.comp]/[text.encoding.cmp].

If I were to make that change now it would complicate matters for Thomas when he tries to apply the additional commits. @tkoeppe, maybe you can make this change afterwards?

Sure, no problem, I'll just swap those two. Thanks!

@tkoeppe tkoeppe mentioned this pull request Jul 21, 2023
Open
@burblebee @tkoeppe
P1885R12 Naming Text Encodings to Demystify Them
ad1e088 
Editorial notes:
- [text.*] Minor changes were made for consistency with existing text.
- [text.encoding.overview] Fix reference for "trivially copyable type".
- [text.encoding.hash] Make section match synopsis; remove stray declaration.
@burblebee @tkoeppe
[bibliography] Move the two IANA entries together.
7798f19
@burblebee @tkoeppe
[text.encoding.members] Use "static_assert" instead of "assert" in ex…
3ca7c13 
…ample.
@tkoeppe tkoeppe merged commit 518d57e into main Jul 21, 2023
4 checks passed
@frederick-vs-ja frederick-vs-ja mentioned this pull request Jul 24, 2023
Closed
@JohelEGP JohelEGP mentioned this pull request Jul 30, 2023
Open
@jensmaurer jensmaurer deleted the motions-2023-06-lwg-17 branch November 12, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoeppe tkoeppe tkoeppe left review comments

@JohelEGP JohelEGP JohelEGP approved these changes

@jensmaurer jensmaurer Awaiting requested review from jensmaurer

Assignees
No one assigned
Labels
changes requested Changes to the wording or approach have been requested and not yet applied.
Projects
None yet
Milestone
post-2023-06
4 participants
@burblebee @tkoeppe @JohelEGP @jensmaurer