Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta.unary.prop.query, meta.trans.arr] Use static_assert instead of assert in example #6363

Merged
merged 2 commits into from Nov 10, 2023

Conversation

hewillk
Copy link
Contributor

@hewillk hewillk commented Jun 29, 2023

Not sure why runtime assert was used on [meta] in the first place.

…f assert in example

Not quite sure why runtime assert was used on [meta] in the first place.
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove the redundant parentheses.

@jwakely
Copy link
Member

jwakely commented Jun 29, 2023

Not sure why runtime assert was used on [meta] in the first place.

Because the example comes straight from TR1 which was based on C++03 and so there was no static_assert in the language.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 10, 2023

Could you rerun the precommit checks?

@hewillk hewillk closed this Nov 10, 2023
@hewillk hewillk reopened this Nov 10, 2023
@tkoeppe tkoeppe merged commit 1ec1d9e into cplusplus:main Nov 10, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants