Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdspan.submdspan] Introduced rank should be _rank_ or dissolved #6365

Open
JohelEGP opened this issue Jun 30, 2023 · 0 comments
Open

[mdspan.submdspan] Introduced rank should be _rank_ or dissolved #6365

JohelEGP opened this issue Jun 30, 2023 · 0 comments

Comments

@JohelEGP
Copy link
Contributor

Introduced rank should be rank or dissolved

[mdspan.submdspan.overview] introduces rank by "let"
in functions with a slices argument within [mdspan.submdspan].
rank is essentially sizeof...(slices)/sizeof...(SliceSpecifier).

In the same [mdspan.submdspan.overview],
it's then used to introduce another "let",
and never to be used again in [mdspan.submdspan].

There are actually many uses of sizeof...(SliceSpecifier) within [mdspan.submdspan]
that can be replaced with the introduced rank.
There's also one use of rank() (which is a different rank) while the introduced rank is in scope.

So I think either, the "let" rank should be renamed to rank or removed.
If not removed, we should consider replacing uses of sizeof...(SliceSpecifier) with rank.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant