Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[namespace.std] Convert unconventional (a) and (b) notation to items #6367

Merged
merged 1 commit into from Nov 10, 2023

Conversation

Eisenwave
Copy link
Contributor

It would be more appropriate in American English to use a comma in this place.

Without the comma, the sentence reads as:

[...] depends on the name of at least one program-defined type and [on something else]

With the comma, the sentence reads as:

[...] depends on the name of at least one program-defined type, and [there is another requirement]

The second reading is correct here, given the rest of the sentence.

@jwakely
Copy link
Member

jwakely commented Jul 6, 2023

I think the use of "(a) something and (b) something else" makes it unambiguous that the second reading is the only correct one. It's not "depends on (a) something and (b) something else".

That said, the use of "(a) and (b)" here is not how we usually specify things. I think we could either replace those with \item to make this a bulleted list (which would still be clear that the "depends on" part only applies to the first requirement), or remove the (a) and (b) and add the comma. I think the bulleted list would be my preference between those two options.

Keeping the (a) and (b) would be my least favourite solution, and with that option adding the comma seems like putting lipstick on a pig.

@Eisenwave Eisenwave changed the title [namespace.std] Add serial comma [namespace.std] Convert unconventianal (a) and (b) notation to items Jul 21, 2023
@Eisenwave
Copy link
Contributor Author

That said, the use of "(a) and (b)" here is not how we usually specify things. I think we could either replace those with \item to make this a bulleted list (which would still be clear that the "depends on" part only applies to the first requirement), or remove the (a) and (b) and add the comma. I think the bulleted list would be my preference between those two options.

I agree. I've implemented this change for the paragraph in question, as well as another paragraph above:

grafik

@Eisenwave Eisenwave changed the title [namespace.std] Convert unconventianal (a) and (b) notation to items [namespace.std] Convert unconventional (a) and (b) notation to items Jul 21, 2023
@jensmaurer
Copy link
Member

@Eisenwave , feel free to squash and force-push the two commits.

@tkoeppe tkoeppe merged commit 60f7bb7 into cplusplus:main Nov 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants