mdspan/layout_stride: fix missed rename in use of template argument name #6385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a typo where it says: LayoutStrideMapping, instead of StridedLayoutMapping. No other use of LayoutStrideMapping exists in the document.
This is in the constructor of
layout_stride::mapping
which takes a constrained other mapping and has remarks for the explicit condition:Remarks: The expression inside
explicit
is equivalent to:!(is_convertible_v<typename StridedLayoutMapping::extents_type, extents_type> && ( is-mapping-of<layout_left, LayoutStrideMapping> || is-mapping-of<layout_right, LayoutStrideMapping> || is-mapping-of<layout_stride, LayoutStrideMapping>))
This needs to be:
!(is_convertible_v<typename StridedLayoutMapping::extents_type, extents_type> && ( is-mapping-of<layout_left, StridedLayoutMapping> || is-mapping-of<layout_right, StridedLayoutMapping> || is-mapping-of<layout_stride, StridedLayoutMapping>))
I am considering this an editorial fix.