Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[span.cons][range.slide.iterator][text.encoding.members] Simplify \tcode{\exposid{name}} to \exposid{name} #6406

Closed

Conversation

frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Jul 23, 2023

As suggested by @JohelEGP. Follows up #5918 and #6359.

Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My favorite suggestion is a script check.

@jensmaurer
Copy link
Member

I have a script check, and it found a few more instances.

How do we best merge this?

@tkoeppe
Copy link
Contributor

tkoeppe commented Jul 23, 2023

Fix the existing violations first, then check in the script?

@frederick-vs-ja frederick-vs-ja changed the title [span.cons] Simplify \tcode{\exposid{name}} to \exposid{name} [span.cons][range.slide.iterator][text.encoding.members] Simplify \tcode{\exposid{name}} to \exposid{name} Jul 24, 2023
@frederick-vs-ja
Copy link
Contributor Author

I think I've fixed all remain violations.

source/ranges.tex Outdated Show resolved Hide resolved
Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
@jensmaurer
Copy link
Member

Superseded by #6456, also adding a check.

@frederick-vs-ja frederick-vs-ja deleted the simplify-span-cons branch August 15, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants