[optional.optional] Remove qualified destructor calls, refactor postconditions of swap CWG1089
#6416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohelEGP
approved these changes
Jul 25, 2023
Hmm, GCC and Clang compile that OK, EDG and MSVC don't. |
|
Thanks! I'm not sure if this PR is really an improvement. Even moving the postconditions out just creates the combinatorial complexity elsewhere that the table was meant to express concisely. Please reopen if you feel strongly, but I'd say let's just leave this. |
This is CWG 1089. |
jensmaurer
changed the title
swapswap CWG1089
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
val->T::~T()should beval->~T()(the former breaks ifThas a member namedT), but considering that 'destroys the contained value' is already sufficiently clear in its meaning, I don't see why explicitly specifying the syntax for a (pseudo-)destructor call is necessary at all.This PR also changes the presentation of postconditions in [optional.swap] by moving them out of the 'Effects' table.