Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gslice.array.comp.assign] Fix missing title #642

Merged
merged 1 commit into from Mar 23, 2016

Conversation

FrankHB
Copy link
Contributor

@FrankHB FrankHB commented Mar 12, 2016

No description provided.

@@ -8228,7 +8228,7 @@
refers.
\end{itemdescr}

\rSec3[gslice.array.comp.assign]{\tcode{gslice_array}}
\rSec3[gslice.array.comp.assign]{\tcode{gslice_array} computed assignment}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should presumably be "compound assignment, not "computed assignment", per [expr.ass]. Please also change "computed assignments" to "compound assignment operators" in the wording on line 8260.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zygoloid I'm not sure if it is correct. "Computed assignments" occurs in many other clauses, i.e. [valarray.syn]/5, [template.valarray.overview], [valarray.cassign], [slice.arr.comp.assign], [mask.array.comp.assign] and [indirect.array.comp.assign]. Is this editorial? Also not sure difference between "cassign" and "comp.assign" is intended.

@zygoloid
Copy link
Member

I suspect someone got this wrong once a long time ago, and then the error was copied into other places.

@FrankHB
Copy link
Contributor Author

FrankHB commented Mar 19, 2016

Is it OK to replace all these occurrence to "compound"?

@zygoloid
Copy link
Member

I expect so. If you put together a patch to do that, I'll go through them all and make sure none of them really did mean something else, but I suspect they're all incorrect.

@FrankHB
Copy link
Contributor Author

FrankHB commented Mar 20, 2016

Done.

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 20, 2016

@FrankHB: Squash, rebase and repush?

@FrankHB FrankHB force-pushed the patch-10 branch 2 times, most recently from 6d423d9 to 429a8ce Compare March 21, 2016 03:52
@FrankHB
Copy link
Contributor Author

FrankHB commented Mar 21, 2016

OK.

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 21, 2016

@zygoloid: PTAL

does \tcode{not} invalidate references or pointers.

\pnum
If the value of an element in the left-hand side of a valarray computed
If the value of an element in the left-hand side of a valarray coumpound
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check spelling

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 21, 2016

Maybe make the commit message something slimmer that's just one line?

…ray.comp.assign].

Signed-off-by: FrankHB <frankhb1989@gmail.com>
@FrankHB
Copy link
Contributor Author

FrankHB commented Mar 23, 2016

Sorry for the typetypo. Fixed.

(I should be typing "typing error" then.) OK... typo :(

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 23, 2016

You mean "typo"? :-)

@zygoloid zygoloid merged commit 5982c16 into cplusplus:master Mar 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants