New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gslice.array.comp.assign] Fix missing title #642
Conversation
@@ -8228,7 +8228,7 @@ | |||
refers. | |||
\end{itemdescr} | |||
|
|||
\rSec3[gslice.array.comp.assign]{\tcode{gslice_array}} | |||
\rSec3[gslice.array.comp.assign]{\tcode{gslice_array} computed assignment} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should presumably be "compound assignment, not "computed assignment", per [expr.ass]. Please also change "computed assignments" to "compound assignment operators" in the wording on line 8260.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zygoloid I'm not sure if it is correct. "Computed assignments" occurs in many other clauses, i.e. [valarray.syn]/5, [template.valarray.overview], [valarray.cassign], [slice.arr.comp.assign], [mask.array.comp.assign] and [indirect.array.comp.assign]. Is this editorial? Also not sure difference between "cassign" and "comp.assign" is intended.
I suspect someone got this wrong once a long time ago, and then the error was copied into other places. |
Is it OK to replace all these occurrence to "compound"? |
I expect so. If you put together a patch to do that, I'll go through them all and make sure none of them really did mean something else, but I suspect they're all incorrect. |
Done. |
@FrankHB: Squash, rebase and repush? |
6d423d9
to
429a8ce
Compare
OK. |
@zygoloid: PTAL |
does \tcode{not} invalidate references or pointers. | ||
|
||
\pnum | ||
If the value of an element in the left-hand side of a valarray computed | ||
If the value of an element in the left-hand side of a valarray coumpound |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check spelling
Maybe make the commit message something slimmer that's just one line? |
…ray.comp.assign]. Signed-off-by: FrankHB <frankhb1989@gmail.com>
Sorry for the (I should be typing "typing error" then.) OK... typo :( |
You mean "typo"? :-) |
No description provided.