Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ostream.formatted.print] Use \impldef macro. #6423

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mordante
Copy link
Contributor

The text defines implementation-defined behavior, but it doesn't use the appropriate macro. So the text is not available in "Index of implementation-defined behavior".

The text defines implementation-defined behavior, but it doesn't use the
appropriate macro. So the text is not available in "Index of
implementation-defined behavior".
@JohelEGP
Copy link
Contributor

See #5693 (comment) for how this macro is used.
That comment also appertains to this specific use.
It was rejected back then.

@JohelEGP
Copy link
Contributor

I think this is also similar to #6359 (comment).

@mordante
Copy link
Contributor Author

Thanks for the links, searching didn't show them. After reading the links I'm still not sure why this is not implementation-defined behavior. The way I read it is "Whether os refers to a terminal capable of displaying Unicode is determined in an implementation-defined manner". Is this the wrong interpretation?

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 8, 2023

@mordante I think the point is that the macro expands to the words "implementation-defined", and the macro argument is the explanatory text that goes into the index.

You can just build the PDF with your changes and check what you get (both in the text and in the index)!

@tkoeppe tkoeppe added the changes requested Changes to the wording or approach have been requested and not yet applied. label Nov 8, 2023
\tcode{os} is a stream that refers to a terminal capable of displaying Unicode
which is determined in an implementation-defined manner,
\tcode{os} is a stream that refers to \impldef{a terminal capable of displaying
Unicode} which is determined in an implementation-defined manner,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifically, this appearance of the word "implementation-defined" must be replaced by \impldef{text to appear in the index}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Changes to the wording or approach have been requested and not yet applied.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants