[except.terminate] Fix missing introductory comma #6446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
approved these changes
Aug 14, 2023
|
"In some situations" isn't really a clause, is it? |
You're right, I think it's merely an introductory phrase, but still one of the cases where a comma feels better because there is a distinct pause. You could even pronounce it as:
See https://owl.purdue.edu/owl/general_writing/punctuation/commas/commas_after_introductions.html |
Eisenwave
changed the title
|
I'm not convinced that this is a strong argument that the comma is "missing". I agree that it's nice to have the comma, but it was fine without the comma, too. I'll reword the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a missing comma after the conditional clause "In some situations,".