Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dlc.init.general] Fix wording of direct-initialization #6450

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Eisenwave
Copy link
Contributor

Firstly, this paragraph should be combining its items with or, not and. Initialization is not called direct-initialization if it's taking place both in a static_cast expression and in a functional notation type conversion at the same time, but rather if one or the other case.

Secondly, it's a little unusual how short the part after the \itemize section is. I think readability if the paragraph started with the defined term instead.

@AlisdairM
Copy link
Contributor

The grammar with and is correct for the current definition, where we collectively mean all of the list. Your reformulation turns this into a conditional with an if, effectively making the list into "one of these places" --- and that is when the or wording would be preferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants