Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[allocator.requirements.general] Fix the misuse of launder #6452

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #4553.

I think the new-expression can render the contents in the storage indeterminate, and the start_lifetime_as_array call can obtain the pointer to the first element even if the element is not within its lifetime.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 11, 2023

See also #4553 (comment)

CWG meeting concensus Nov 11: Not editorial.

We definitely see an issue here. It might be whether the precondtions of launder are correct, and that should become an issue (LWG or CWG).

We might not want to make the proposed change here until that issue has been resolved.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 11, 2023

@jwakely: If we made this an LWG issue, would LWG do anything with it other than immediately send it to CWG?

@tkoeppe tkoeppe added not-editorial Issue is not deemed editorial; the editorial issue is kept open for tracking. lwg Issue must be reviewed by LWG. labels Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cwg Issue must be reviewed by CWG. lwg Issue must be reviewed by LWG. not-editorial Issue is not deemed editorial; the editorial issue is kept open for tracking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example in [allocator.requirements.general] incorrectly uses launder?
2 participants