[over.ics.list] expand example 5, fix inconsistent spacing #6454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eisenwave
force-pushed
the
expand-init-list-example
branch
from
07f02ff
to
5a30a0c
Compare
|
The spacing fix is fine. I'm not comfortable adding the example editorially. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This edit expands the example to include the edge case where the
std::initializer_listconstructors competes with the copy constructor. This edge case has been the subject of some core issues:It's also responsible for an LLVM bug where the copy constructor wins in overload resolution, and this is actively being worked on:
To raise awareness for this issue, and how the edge case should be handled, it would be wise to include it in the example.
Furthermore, this edit fixes inconsistent comma spacing towards the beginning of the example. While the style is up to the author of the examples, they should at least follow consistent style, and not space
1,2,3in one place, but1.0, 2.0in another.